src: remove shadowed variable in OptionsParser::Parse#46672
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 1, 2023
Merged
src: remove shadowed variable in OptionsParser::Parse#46672nodejs-github-bot merged 1 commit intonodejs:mainfrom
OptionsParser::Parse#46672nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium enabled
-Wshadowin https://chromium-review.googlesource.com/c/chromium/src/+/3860569, which meant that this code caused compilation issues in Electron.Fix this with name change.